RFR: 8358680: AOT cache creation fails: no strings should have been added [v2]

[Aleksey Shipilev]

On Fri, 27 Jun 2025 15:47:04 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/classfile/stringTable.cpp line 970:
>> 
>>> 968:   // This flag will be cleared after intern table dumping has completed, so we can run the
>>> 969:   // compiler again (for future AOT method compilation, etc).
>>> 970:   DEBUG_ONLY(Atomic::release_store(&_disable_interning_during_cds_dump, 1));
>> 
>> I think atomics work with bool or is this a refcount ?
>
> I tried to changed to a `bool` but Atomics doesn't like that. I got an compilation error.

Atomics are supposed to work with `bool`-s. I looked around, and this was the first hit:
https://github.com/openjdk/jdk/blob/282ee40a56af46521b94fe6e4c90e78b8f513b29/src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp#L60

Also, I just tried to switch `_disable_interning_during_cds_dump` to `bool` in this PR branch, and it worked at least on Linux x86_64. Can you try again and post what compilation error you are seeing?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25816#discussion_r2178199104