RFR: 8357424: [JVMCI] Avoid incrementing decompilation count for hosted compiled nmethod [v7]

Yudi Zheng yzheng at openjdk.org
Wed Jul 2 07:24:42 UTC 2025


On Fri, 13 Jun 2025 20:59:05 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Yudi Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Merge tag 'jdk-26+2' into JDK-8357424
>>    
>>    Added tag jdk-26+2 for changeset d7aa3498
>>  - fix compilation error
>>  - address comments
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8357424
>>  - address comments
>>  - address comments
>>  - update copyright
>>  - [JVMCI] Avoid incrementing decompilation count for hosted compiled nmethod
>
> src/hotspot/share/code/nmethod.cpp line 1951:
> 
>> 1949:   // Could be gated by ProfileTraps, but do not bother...
>> 1950: #if INCLUDE_JVMCI
>> 1951:   if (is_jvmci_hosted()) {
> 
> Someone (like me!) is going to see this code a while from now and try remember why the decompilation count is not being decremented for JVMCI hosted nmethods. I think it's worth adding a comment.

See https://github.com/openjdk/jdk/pull/25356/commits/022546a09ed9ca06898459df2f7b6ddc2877f69b

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25356#discussion_r2179317632


More information about the hotspot-dev mailing list