RFR: 8359359: AArch64: share trampolines between static calls to the same method [v2]
Mikhail Ablakatov
mablakatov at openjdk.org
Wed Jul 2 15:56:28 UTC 2025
On Mon, 30 Jun 2025 22:52:42 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> Mikhail Ablakatov has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Lift the vm.opt.TieredCompilation == null requirement from the tests
>> - Combine the two shared trampoline request hash tables
>
> test/hotspot/jtreg/compiler/sharedstubs/SharedStaticCallTrampolineTest.java line 33:
>
>> 31: *
>> 32: * @requires vm.compiler2.enabled
>> 33: * @requires vm.opt.TieredCompilation == null
>
> I don't think
> @requires vm.opt.TieredCompilation == null
> is needed here.
> Test always overrides TieredCompilation mode.
>
> The problem is that the test is going to be skipped if someone run testing with -XX:-TieredCompilation to test C2 changes. Please just remove this line so test is executed anytime if C2 is available.
>
> The renamed test 'SharedRuntimeCallTrampolineTest' seems to have this problem also.
Thank you for a review @lmesnik , fixed!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25954#discussion_r2180415094
More information about the hotspot-dev
mailing list