RFR: 8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays
Coleen Phillimore
coleenp at openjdk.org
Tue Jul 8 20:25:39 UTC 2025
On Tue, 8 Jul 2025 02:17:01 GMT, David Holmes <dholmes at openjdk.org> wrote:
> The original PR (https://github.com/openjdk/jdk/pull/26123) had incorrect usage of `SafeFetch32`. This PR replaces that with the use of `os::is_readable_range` as proposed by @tstuefe (thank you!). In addition I found that code was no longer getting exercised by the regression test so I added a gtest for that (during which it was discovered that the new implementation in `verify` requires any gtest that uses it to be `TEST_VM` rather than `TEST`).
>
> Testing: tiers 1-4
>
> Thanks
This looks good. is_readable_range avoids unaligned SafeFetch32, right?
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26177#pullrequestreview-2999007489
More information about the hotspot-dev
mailing list