RFR: 8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError [v3]
David Holmes
dholmes at openjdk.org
Tue Jul 8 21:25:56 UTC 2025
> In [JDK-8186092](https://bugs.openjdk.org/browse/JDK-8186092) (way back in JDK 10) we elided loader constraint checks for overpass methods related to default methods by skipping them when initializing the itable for the interface. But that was the wrong thing to do. The overpass method is setup when there is a resolution/selection error so that the correct exception is thrown if the problematic method is invoked (like the ICCE reporting conflicting methods) and by eliding that entry we instead get the `AbstractMethhodError`.
>
> The fix here is to revert that change from [JDK-8186092](https://bugs.openjdk.org/browse/JDK-8186092), and to address the loader constraint problem by adding the same check for overpass methods in `klassItable::check_constraints` that exists for `klassVtable::check_constraints`.
>
> Testing:
> - modified existing regression test
> - tiers 1-4
>
> EDIT: originally there was a new regression test for this, but this area is already covered by the `vmTestBase` "`defmeth` tests. That test was missing the necessary invocation modes to expose the bug, so they have been added.
>
> Thanks
>
> PS. The diff is much smaller if you disable whitespace differences.
David Holmes has updated the pull request incrementally with one additional commit since the last revision:
Fix weird logic - requested by Coleen
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26122/files
- new: https://git.openjdk.org/jdk/pull/26122/files/29883542..d12213e3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26122&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26122&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/26122.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26122/head:pull/26122
PR: https://git.openjdk.org/jdk/pull/26122
More information about the hotspot-dev
mailing list