RFR: 8358580: Rethink how classes are kept alive in training data [v2]
Coleen Phillimore
coleenp at openjdk.org
Thu Jul 10 17:14:38 UTC 2025
On Thu, 10 Jul 2025 17:10:22 GMT, Igor Veresov <iveresov at openjdk.org> wrote:
>> Use OopStorage directly instead of JNI handles. Note that we never destroy TrainingData objects, so we don't need to concern ourselves with freeing the OopStorage entries. Also, keeping the klasses alive is only necessary during the training run. During the replay the klasses TD objects refer to are always alive.
>
> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review comments
Looks good. thanks for the comment.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26233#pullrequestreview-3006599873
More information about the hotspot-dev
mailing list