RFR: 8362587: Sort share/oops includes
Aleksey Shipilev
shade at openjdk.org
Fri Jul 18 10:33:29 UTC 2025
On Fri, 18 Jul 2025 10:25:41 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:
> This PR sorts the includes in `hotspot/share/oops` using `test/hotspot/jtreg/sources/SortIncludes.java`. I'm also adding the directory to `TestIncludesAreSorted.java`.
>
> Passes tier1 and tier2 tests.
Let's see if this breaks any builds. Meanwhile, see comments.
Also, can you please explicitly run `make test TEST=sources/TestIncludesAreSorted.java` to make sure it works?
test/hotspot/jtreg/sources/TestIncludesAreSorted.java line 51:
> 49: "share/jvmci",
> 50: "share/opto",
> 51: "share/oops"
This order does not look lexicographic? `oops` < `opto`?
-------------
PR Review: https://git.openjdk.org/jdk/pull/26386#pullrequestreview-3033030746
PR Review Comment: https://git.openjdk.org/jdk/pull/26386#discussion_r2215695844
More information about the hotspot-dev
mailing list