RFR: 8363584: Sort share/utilities includes [v3]
Francesco Andreuzzi
duke at openjdk.org
Thu Jul 24 08:56:55 UTC 2025
On Tue, 22 Jul 2025 19:31:20 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> typo
>
> src/hotspot/share/utilities/globalDefinitions_visCPP.hpp line 50:
>
>> 48: // Need this on windows to get the math constants (e.g., M_PI).
>> 49: #define _USE_MATH_DEFINES
>> 50: # include <math.h>
>
> There's a separate problem, unrelated to include order cleanup, that `_USE_MATH_DEFINES` is being
> defined here, as that's too late if `<math.h>` happened to be included already. I'll file a bug to address that.
> (Apparently not causing problems currently, but include reorderings could trigger problems.)
https://bugs.openjdk.org/browse/JDK-8363885
I moved it before all the include statements for now, should be fine until JDK-8363885 is addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26428#discussion_r2227888502
More information about the hotspot-dev
mailing list