RFR: 8362564: hotspot/jtreg/compiler/c2/TestLWLockingCodeGen.java fails on static JDK on x86_64 with AVX instruction extensions

[Jiangli Zhou]

On Thu, 24 Jul 2025 09:30:45 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Please review this fix that increases the x86 initial stubs size to `21000` for `NOT_PRODUCT` only case.
>> 
>> Also included as part of the PR (suggested by @rasbold), moved the assert to after the `stubs` log info output.
>
> src/hotspot/share/runtime/stubRoutines.cpp line 170:
> 
>> 168:   // When new stubs added we need to make sure there is some space left
>> 169:   // to catch situation when we should increase size again.
>> 170:   assert(code_size == 0 || buffer.insts_remaining() > 200, "increase %s", assert_msg);
> 
> What is the reason to move the assert?

@eastig Thanks for taking a look!

The log `Info, stubs` output provides useful details. With the assertion failure, it wouldn't show. That's why moving the assert to after the log output.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26395#discussion_r2229710100