RFR: 8363584: Sort share/utilities includes [v4]
David Holmes
dholmes at openjdk.org
Fri Jul 25 05:35:05 UTC 2025
On Thu, 24 Jul 2025 21:06:11 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> more sorting
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 29:
>
>> 27:
>> 28: // Get constants like JVM_T_CHAR and JVM_SIGNATURE_INT, before pulling in <jvm.h>.
>> 29: #include "classfile_constants.h"
>
> This include may no longer be needed, since `jvm.h` includes `jvm_constants.h`, which
> includes `classfile_constants.h`. (As it should. Presumably it didn't used to and there was
> an include-order problem as a result.) But that doesn't need to be addressed in this PR.
> It can be dealt with in a new followup issue, and just stick to the sorting problems here.
> https://bugs.openjdk.org/browse/JDK-8364087
I don't know what the comment is referring to as this file doesn't include jvm.h, but it does need the constants.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26428#discussion_r2230186490
More information about the hotspot-dev
mailing list