RFR: 8364004: Expose VMError::controlledCrash via Whitebox [v2]
Thomas Stuefe
stuefe at openjdk.org
Mon Jul 28 06:46:28 UTC 2025
On Mon, 28 Jul 2025 06:30:53 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback kim
>
> Changes requested by kbarrett (Reviewer).
@kimbarrett Thanks for the review. Done.
> src/hotspot/share/prims/whitebox.cpp line 2734:
>
>> 2732: WB_ENTRY(void, WB_ControlledCrash(JNIEnv* env, jobject o, jint how))
>> 2733: #ifdef ASSERT
>> 2734: DEBUG_ONLY(VMError::controlled_crash(how);)
>
> `DEBUG_ONLY` wrapping isn't needed here, since we're in `#ifdef ASSERT` context.
Thanks, that was a remnant from an earlier version. Fixed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26472#issuecomment-3125755944
PR Review Comment: https://git.openjdk.org/jdk/pull/26472#discussion_r2234896069
More information about the hotspot-dev
mailing list