RFR: 8278874: tighten VerifyStack constraints [v2]

[Manuel Hässig]

On Thu, 24 Jul 2025 19:03:24 GMT, Dean Long <dlong at openjdk.org> wrote:

>> src/hotspot/share/runtime/deoptimization.cpp line 847:
>> 
>>> 845: 
>>> 846: #ifndef PRODUCT
>>> 847: #ifdef ASSERT
>> 
>> Why is both `NOT_PRODUCT` and `ASSERT` needed here? So far, I thought that `ASSERT` implies `NOT_PRODUCT`.
>
> Unfortunately, they are not the same, thanks to "optimized" builds.  We can clean this up if optimizes builds get removed.  See https://bugs.openjdk.org/browse/JDK-8183287.

Ah, "optimized" is with neither `ASSERT` nor `PRODUCT` defined. Makes sense now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26121#discussion_r2235198526