RFR: 8278874: tighten VerifyStack constraints [v7]

Manuel Hässig mhaessig at openjdk.org
Mon Jul 28 08:36:55 UTC 2025


On Thu, 24 Jul 2025 20:03:33 GMT, Dean Long <dlong at openjdk.org> wrote:

>> The VerifyStack logic in Deoptimization::unpack_frames() attempts to check the expression stack size of the interpreter frame against what GenerateOopMap computes.  To do this, it needs to know if the state at the current bci represents the "before" state, meaning the bytecode will be reexecuted, or the "after" state, meaning we will advance to the next bytecode.  The old code didn't know how to determine exactly what state we were in, so it checked both.  This PR cleans that up, so we only have to compute the oopmap once.  It also removes old SPARC support.
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   readability suggestion

Thank you for addressing my comments. I have done another pass and it looks good to me.

-------------

Marked as reviewed by mhaessig (Committer).

PR Review: https://git.openjdk.org/jdk/pull/26121#pullrequestreview-3061222726


More information about the hotspot-dev mailing list