RFR: 8362564: hotspot/jtreg/compiler/c2/TestLWLockingCodeGen.java fails on static JDK on x86_64 with AVX instruction extensions [v2]
Vladimir Kozlov
kvn at openjdk.org
Tue Jul 29 22:14:00 UTC 2025
On Tue, 29 Jul 2025 18:17:14 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address @eastig review comment:
>> - Reverted change for moving the assert. Added code_size, buffer size and free to the assert output.
>
> There was no GHA testing for this.
> @vnkozlov Do you refer to the PR testing? It's https://github.com/openjdk/jdk/pull/26395/checks, thanks.
Yes, that. I did not realize that GitHub removes it from main PR tab after integration.
Good, it was tested. I think GitHub actions use AVX512 machines. But I remember that static build testing was excluded.
First, I am fine with fix you pushed. But it is strange.
There should be no difference in stubs sizes running with regular JDK on avx512 machine and static JDK. I don't see how we don't trigger this issue in our testing - we regularly running on AVX512 machines.
Do you have additional code somewhere in macro assembler for static build? Is it possible to compare assembler code?
I see you posted sizes in bug report. Can you compare code for `StubRoutines::forward_exception()` which has smallest size to see what is difference.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26395#issuecomment-3134218373
More information about the hotspot-dev
mailing list