RFR: 8364037: Sort share includes: adlc, libadt, metaprogramming

Christian Hagedorn chagedorn at openjdk.org
Wed Jul 30 05:55:53 UTC 2025


On Thu, 24 Jul 2025 13:19:36 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

> This PR sorts includes using test/hotspot/jtreg/sources/SortIncludes.java in:
> - hotspot/share/adlc 
> - hotspot/share/libadt
> - hotspot/share/metaprogramming
> 
> I noticed some missing includes in several header files in`adlc/`, which caused compilation success to be dependent on the order of include statements in `adlc.hpp`. I moved the include statements to `adlparse.hpp` and `forms.hpp`.
> 
> I'm also adding the directory to TestIncludesAreSorted.java.
> 
> Passes tier1 and GHA.

Looks good, thanks for cleaning it up!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26460#pullrequestreview-3069974635


More information about the hotspot-dev mailing list