RFR: 8364037: Sort share includes: adlc, libadt, metaprogramming

[Albert Mingkun Yang]

On Thu, 24 Jul 2025 13:19:36 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

> This PR sorts includes using test/hotspot/jtreg/sources/SortIncludes.java in:
> - hotspot/share/adlc 
> - hotspot/share/libadt
> - hotspot/share/metaprogramming
> 
> I noticed some missing includes in several header files in`adlc/`, which caused compilation success to be dependent on the order of include statements in `adlc.hpp`. I moved the include statements to `adlparse.hpp` and `forms.hpp`.
> 
> I'm also adding the directory to TestIncludesAreSorted.java.
> 
> Passes tier1 and GHA.

src/hotspot/share/libadt/dict.cpp line 29:

> 27: // %%%%% includes not needed with AVM framework - Ungar
> 28: 
> 29: #include "libadt/dict.hpp"

Usually, "includes" proceeds doc-comments. Can you move up `assert.h` instead? (Also, I didn't find assert-usage in this file. Is it actually needed?)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26460#discussion_r2241786693