RFR: 8364037: Sort share includes: adlc, libadt, metaprogramming [v2]
Francesco Andreuzzi
duke at openjdk.org
Wed Jul 30 08:49:13 UTC 2025
> This PR sorts includes using test/hotspot/jtreg/sources/SortIncludes.java in:
> - hotspot/share/adlc
> - hotspot/share/libadt
> - hotspot/share/metaprogramming
>
> I noticed some missing includes in several header files in`adlc/`, which caused compilation success to be dependent on the order of include statements in `adlc.hpp`. I moved the include statements to `adlparse.hpp` and `forms.hpp`.
>
> I'm also adding the directory to TestIncludesAreSorted.java.
>
> Passes tier1 and GHA.
Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
assert not needed. move up
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26460/files
- new: https://git.openjdk.org/jdk/pull/26460/files/82a437cb..bcddcb9e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26460&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26460&range=00-01
Stats: 7 lines in 1 file changed: 2 ins; 4 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/26460.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26460/head:pull/26460
PR: https://git.openjdk.org/jdk/pull/26460
More information about the hotspot-dev
mailing list