RFR: 8364037: Sort share includes: adlc, libadt, metaprogramming [v2]

Wed Jul 30 09:09:54 UTC 2025

On Wed, 30 Jul 2025 08:49:13 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

>> This PR sorts includes using test/hotspot/jtreg/sources/SortIncludes.java in:
>> - hotspot/share/adlc 
>> - hotspot/share/libadt
>> - hotspot/share/metaprogramming
>> 
>> I noticed some missing includes in several header files in`adlc/`, which caused compilation success to be dependent on the order of include statements in `adlc.hpp`. I moved the include statements to `adlparse.hpp` and `forms.hpp`.
>> 
>> I'm also adding the directory to TestIncludesAreSorted.java.
>> 
>> Passes tier1 and GHA.
>
> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   assert not needed. move up

Marked as reviewed by ayang (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/26460#pullrequestreview-3070543595