RFR: 8364037: Sort share includes: adlc, libadt, metaprogramming [v3]

Francesco Andreuzzi duke at openjdk.org
Wed Jul 30 10:36:15 UTC 2025


> This PR sorts includes using test/hotspot/jtreg/sources/SortIncludes.java in:
> - hotspot/share/adlc 
> - hotspot/share/libadt
> - hotspot/share/metaprogramming
> 
> I noticed some missing includes in several header files in`adlc/`, which caused compilation success to be dependent on the order of include statements in `adlc.hpp`. I moved the include statements to `adlparse.hpp` and `forms.hpp`.
> 
> I'm also adding the directory to TestIncludesAreSorted.java.
> 
> Passes tier1 and GHA.

Francesco Andreuzzi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into JDK-8364037
 - assert not needed. move up
 - move comment
 - sort

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26460/files
  - new: https://git.openjdk.org/jdk/pull/26460/files/bcddcb9e..caf2a092

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26460&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26460&range=01-02

  Stats: 4763 lines in 253 files changed: 2027 ins; 2203 del; 533 mod
  Patch: https://git.openjdk.org/jdk/pull/26460.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26460/head:pull/26460

PR: https://git.openjdk.org/jdk/pull/26460


More information about the hotspot-dev mailing list