RFR: 8357086: os::xxx functions returning memory size should return size_t [v15]

[Anton Artemov]

On Wed, 30 Jul 2025 14:46:09 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8357086: Addressed reviewer's comments
>
> src/hotspot/share/jfr/periodic/jfrPeriodic.cpp line 551:
> 
>> 549:   if (!os::total_swap_space(total_swap_space)) {
>> 550:     log_debug(jfr, system)("os::total_swap_space() failed");
>> 551:   }
> 
> Suggestion:
> 
>   // Ignore return value
>   (void)os::total_swap_space(total_swap_space);

Removed.

> src/hotspot/share/jfr/periodic/jfrPeriodic.cpp line 556:
> 
>> 554:   if (!os::free_swap_space(free_swap_space)) {
>> 555:     log_debug(jfr, system)("os::free_swap_space() failed");
>> 556:   }
> 
> Suggestion:
> 
>   // Ignore return value
>   (void)os::free_swap_space(free_swap_space);

Removed.

> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1364:
> 
>> 1362:     if (!os::available_memory(avail_mem)) {
>> 1363:       log_debug(redefine, class, load)("os::available_memory() failed");
>> 1364:     }
> 
> Suggestion:
> 
>     // Ignore return value
>     (void)os::available_memory(avail_mem);

Removed.

> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4446:
> 
>> 4444:     if (!os::available_memory(avail_mem)) {
>> 4445:       log_debug(redefine, class, load)("os::available_memory() failed");
>> 4446:     }
> 
> Suggestion:
> 
>     // Ignore return value
>     (void)os::available_memory(avail_mem);

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2243058838
PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2243059007
PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2243059185
PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2243059382