RFR: 8364087: Amend comment in globalDefinitions.hpp on "classfile_constants.h" include [v2]
Francesco Andreuzzi
duke at openjdk.org
Thu Jul 31 12:30:46 UTC 2025
> The comment was introduced in [8231844](https://github.com/fandreuz/jdk/commit/fce43203699336e9513d06cd54b66735e93234a4). I looked around, and `<jvm.h>` is not included in any of the headers included by `globalDefinitions.hpp`, neither now nor in the original commit. Thus, I propose to amend the comment, as it [turned out to be confusing](https://github.com/openjdk/jdk/pull/26428/files#r2229575525) during an header clean up.
>
> Including `classfile_constants.h` is needed for e.g. `JVM_T_CHAR`, as stated by the comment, thus I'm going to leave that part intact.
Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
remove comment
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26573/files
- new: https://git.openjdk.org/jdk/pull/26573/files/8a551a1e..29231a33
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26573&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26573&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/26573.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26573/head:pull/26573
PR: https://git.openjdk.org/jdk/pull/26573
More information about the hotspot-dev
mailing list