RFR: 8363998: Implement Compressed Class Pointers for 32-bit [v5]
Thomas Stuefe
stuefe at openjdk.org
Thu Jul 31 14:41:06 UTC 2025
On Thu, 31 Jul 2025 14:31:49 GMT, ExE Boss <duke at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
>>
>> - Fix some jtreg tests on arm
>> - fix arm gtests
>> - fix CompressedKlass* gtests on arm
>> - Merge master
>> - get rid of NEEDS_CLASS_SPACE define
>> - Merge branch 'master' into JDK-8363998-Implement-compressed-class-pointers-for-32-bit-platforms
>> - Merge branch 'master' into JDK-8363998-Implement-compressed-class-pointers-for-32-bit-platforms
>> - since to because
>>
>> Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
>> - Remove stray include
>> - Update src/hotspot/share/oops/compressedKlass.cpp
>>
>> Co-authored-by: ExE Boss <3889017+ExE-Boss at users.noreply.github.com>
>> - ... and 10 more: https://git.openjdk.org/jdk/compare/559795b0...e4a0f42f
>
> test/hotspot/gtest/metaspace/test_metaspaceUtils.cpp line 105:
>
>> 103: check_metaspace_stats_are_consistent(combined_stats.non_class_space_stats());
>> 104:
>> 105: if (CompressedKlassPointers::needs_class_space() && UseCompressedClassPointers) {
>
> For consistency:
> Suggestion:
>
> if (UseCompressedClassPointers && CompressedKlassPointers::needs_class_space()) {
Why?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26491#discussion_r2245592312
More information about the hotspot-dev
mailing list