Integrated: 8364087: Amend comment in globalDefinitions.hpp on "classfile_constants.h" include

Francesco Andreuzzi duke at openjdk.org
Thu Jul 31 14:46:11 UTC 2025


On Thu, 31 Jul 2025 11:00:07 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

> The comment was introduced in [8231844](https://github.com/fandreuz/jdk/commit/fce43203699336e9513d06cd54b66735e93234a4). I looked around, and `<jvm.h>` is not included in any of the headers included by `globalDefinitions.hpp`, neither now nor in the original commit. Thus, I propose to amend the comment, as it [turned out to be confusing](https://github.com/openjdk/jdk/pull/26428/files#r2229575525) during an header clean up. 
> 
> Including `classfile_constants.h` is needed for e.g. `JVM_T_CHAR`, as stated by the comment, thus I'm going to leave that part intact.

This pull request has now been integrated.

Changeset: 53d152e7
Author:    Francesco Andreuzzi <andreuzzi.francesco at gmail.com>
Committer: Albert Mingkun Yang <ayang at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/53d152e7dbccae9682e461e51ca75d63f88893cf
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

8364087: Amend comment in globalDefinitions.hpp on "classfile_constants.h" include

Reviewed-by: stefank, ayang

-------------

PR: https://git.openjdk.org/jdk/pull/26573


More information about the hotspot-dev mailing list