RFR: 8278874: tighten VerifyStack constraints [v7]

[Dean Long]

On Thu, 31 Jul 2025 21:02:01 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   readability suggestion
>
> src/hotspot/share/runtime/deoptimization.cpp line 971:
> 
>> 969: 
>> 970:         cur_code = str.next();
>> 971:         reexecute = true;
> 
> This seems a little unsavory, particularly since there's a later step which will print that value as if it was the original one.  Since there's only one later logic use of the variable maybe there's should be a new flag to mark special case?  Like `rolled_forward`?  It might be fine as is with comments explaining this and fixing the printing to reflect what occurred here.

OK, I cleaned this up a bit.  I think this code could be cleaned up further and use fewer variables, but I'd like to save that for another day.

> src/hotspot/share/runtime/deoptimization.cpp line 995:
> 
>> 993:       int map_expr_invoke_ssize = mask.expression_stack_size() + cur_invoke_parameter_size;
>> 994:       int expr_ssize_before = iframe_expr_ssize + (is_top_frame ? top_frame_expression_stack_adjustment : 0);
>> 995:       int map_expr_callee_ssize = mask.expression_stack_size() + callee_size_of_parameters;
> 
> `map` in these names might be more clearly `oopmap`.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26121#discussion_r2246507655
PR Review Comment: https://git.openjdk.org/jdk/pull/26121#discussion_r2246507871