RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v25]
Johannes Bechberger
jbechberger at openjdk.org
Sun Jun 1 07:13:00 UTC 2025
On Sat, 31 May 2025 10:37:29 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove debug printf
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.hpp line 139:
>
>> 137:
>> 138: // Trigger sampling while a thread is not in a safepoint, from a seperate thread
>> 139: static void trigger_is_thread_in_native_stackwalking();
>
> Is it sampling that is triggered? Sampling refers to the asynchronous signal received from the operating system (OS).
>
> You are asking for the sampler thread to process already taken JFR Sample Requests in the queue, right?
Yes and I like your implied name better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2118819169
More information about the hotspot-dev
mailing list