RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v26]
Johannes Bechberger
jbechberger at openjdk.org
Sun Jun 1 15:39:00 UTC 2025
On Sun, 1 Jun 2025 15:32:08 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Refactoring
>> - Remove convoluted native trace logic
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 536:
>
>> 534: }
>> 535:
>> 536: volatile size_t count__ = 0;
>
> unused?
Yes.
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 586:
>
>> 584: JfrCPUTimeThreadSampling::trigger_async_processing_of_cpu_time_jfr_requests();
>> 585: } else {
>> 586: tl->set_do_async_processing_of_cpu_time_jfr_requests(false);
>
> Was it true before and needed a reset?
I could check this before setting
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2119260755
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2119261558
More information about the hotspot-dev
mailing list