RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v26]
Markus Grönlund
mgronlun at openjdk.org
Sun Jun 1 18:31:58 UTC 2025
On Sun, 1 Jun 2025 18:22:10 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Refactoring
>> - Remove convoluted native trace logic
>
> src/hotspot/share/jfr/periodic/sampling/jfrThreadSampling.cpp line 250:
>
>> 248: }
>> 249:
>> 250: biased = true;
>
> Perhaps set on entry, and only keep the single biased = false below?
Also, note you have a direct hit in line 221--222 above - it's biased = false.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2119404072
More information about the hotspot-dev
mailing list