RFR: 8255082: HotSpot Style Guide should permit noexcept [v2]
Kim Barrett
kbarrett at openjdk.org
Mon Jun 2 08:21:34 UTC 2025
On Mon, 2 Jun 2025 06:58:39 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>>
>> dholmes review
>
> doc/hotspot-style.md line 1139:
>
>> 1137: such a function `noexcept` informs the compiler that `nullptr` is a possible
>> 1138: result. If an allocation function is not declared `noexcept` then the compiler
>> 1139: may elide that checking and handling for a using `new` expression.
>
> Suggestion:
>
> may elide that checking and handling for a `new` expression.
Instead changed to
"may elide that checking and handling for a `new` expression calling that
function."
It's not _any_ `new` expression that might have stuff elided, only one that calls the not-nothrow
allocation function.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25574#discussion_r2120385617
More information about the hotspot-dev
mailing list