RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v26]
Johannes Bechberger
jbechberger at openjdk.org
Mon Jun 2 08:47:01 UTC 2025
On Sun, 1 Jun 2025 13:05:44 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Refactoring
>> - Remove convoluted native trace logic
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 367:
>
>> 365: JfrCPUTimeSampleRequest& request = queue.at(i);
>> 366: JfrStackTrace stacktrace;
>> 367: traceid tid = JfrThreadLocal::thread_id(thread);
>
> Check the tid as a function of the JfrSampleRequest, like we do in JFR Cooperative Sampling.
You mean ` const traceid tid = in_continuation ? tl->vthread_id_with_epoch_update(jt) : JfrThreadLocal::jvm_thread_id(jt);`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2120458307
More information about the hotspot-dev
mailing list