RFR: 8337666: AArch64: SHA3 GPR intrinsic [v4]
Andrew Haley
aph at openjdk.org
Tue Jun 3 14:24:59 UTC 2025
On Sat, 31 May 2025 08:39:36 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'openjdk:master' into JDK-8337666
>> - Assert message
>> - Copyright year
>> - Review suggestions
>> - Merge master
>> - Delete empty line
>> - SHA3 GPR intrinsic & tests
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 331:
>
>> 329:
>> 330: inline void rol(Register Rd, Register Rn, unsigned imm) {
>> 331: extr(Rd, Rn, Rn, ((64 - imm) & 63));
>
> Suggestion:
>
> extr(Rd, Rn, Rn, (64 - imm));
>
> It's better to catch an out-of-range immediate value.
`rolw` too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24260#discussion_r2124008640
More information about the hotspot-dev
mailing list