RFR: 8357396: Refactor nmethod::make_not_entrant to use Enum instead of "const char*" [v5]

Aleksey Shipilev shade at openjdk.org
Tue Jun 3 20:01:29 UTC 2025


On Tue, 3 Jun 2025 19:33:57 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> Please review this refactor to transform the reasons for making an nmethod not entrant from `const char*` into enum values.
>> 
>> Tested on Linux x64 with JTREG tier1-3 in fastdebug and release mode.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert change to attribute of make_not_entrant element

Looks good to me. Compiler folks might want to ack as well.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25338#pullrequestreview-2893925727


More information about the hotspot-dev mailing list