RFR: 8358003: KlassTrainingData initializer reads garbage holder [v2]
Igor Veresov
iveresov at openjdk.org
Tue Jun 3 22:55:16 UTC 2025
On Tue, 3 Jun 2025 22:37:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> No need for release_store()
>
> src/hotspot/share/oops/trainingData.cpp line 437:
>
>> 435: assert(klass != nullptr, "");
>> 436: Handle hm(JavaThread::current(), klass->java_mirror());
>> 437: jobject hmj = JNIHandles::make_global(hm);
>
> Why don't you use OopStorage for this?
Are there any advantages?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25623#discussion_r2125071202
More information about the hotspot-dev
mailing list