RFR: 8358003: KlassTrainingData initializer reads garbage holder [v2]

Igor Veresov iveresov at openjdk.org
Wed Jun 4 00:56:17 UTC 2025


On Tue, 3 Jun 2025 22:52:26 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> src/hotspot/share/oops/trainingData.cpp line 437:
>> 
>>> 435:   assert(klass != nullptr, "");
>>> 436:   Handle hm(JavaThread::current(), klass->java_mirror());
>>> 437:   jobject hmj = JNIHandles::make_global(hm);
>> 
>> Why don't you use OopStorage for this?
>
> Are there any advantages?

Ok, transitioned to OopStrage. Please take a look if correctly. I'll be back when the testing is done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25623#discussion_r2125208972


More information about the hotspot-dev mailing list