RFR: 8357396: Refactor nmethod::make_not_entrant to use Enum instead of "const char*" [v5]

Manuel Hässig mhaessig at openjdk.org
Thu Jun 5 10:43:53 UTC 2025


On Tue, 3 Jun 2025 19:33:57 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> Please review this refactor to transform the reasons for making an nmethod not entrant from `const char*` into enum values.
>> 
>> Tested on Linux x64 with JTREG tier1-3 in fastdebug and release mode.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert change to attribute of make_not_entrant element

Thank you for addressing the comments. It looks good now.

I ran some additional testing that passed.

-------------

Marked as reviewed by mhaessig (Author).

PR Review: https://git.openjdk.org/jdk/pull/25338#pullrequestreview-2899791829


More information about the hotspot-dev mailing list