RFR: 8358032: Use crypto pmull for CRC32/CRC32C intrinsics on Ampere CPU [v4]
Andrew Haley
aph at openjdk.org
Fri Jun 6 09:49:58 UTC 2025
On Fri, 6 Jun 2025 09:44:54 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> According to perf, post-increment ops help to reduce the access to TLB on Ampere1 in this case.
>
>> According to perf, post-increment ops help to reduce the access to TLB on Ampere1 in this case.
>
> Hmm, but it's code in a rather odd style in shared code. And from what I see, the intrinsic is only 22% of the runtime (for 128 bytes) anyway, and you're making the code larger. I certainly don't want to see this sort of thing proliferating in the intrinsics.
>
> In general, it's up to CPU designers to make simple, straightforward code work well.
>
> How important is this?
On the other hand this code already exists in CRC32C, so it's simply unifying the two routines. OK, I won't object.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25609#discussion_r2131889129
More information about the hotspot-dev
mailing list