RFR: 8352565: Add native method implementation of Reference.get() [v10]
Vladimir Ivanov
vlivanov at openjdk.org
Fri Jun 6 18:55:57 UTC 2025
On Fri, 6 Jun 2025 06:00:48 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Please review this change which adds a native method providing the
>> implementation of Reference::get. Referece::get is an intrinsic candidate, so
>> this native method implementation is only used when the intrinsic is not.
>>
>> Currently there is intrinsic support by the interpreter, C1, C2, and graal,
>> which are always used. With this change we can later remove all the
>> per-platform interpreter intrinsic implementations, and might also remove the
>> C1 intrinsic implementation.
>>
>> Testing:
>> (1) mach5 tier1-6 normal (so using all the existing intrinsics).
>> (2) mach5 tier1-6 with interpreter and C1 Reference::get intrinsics disabled.
>
> Kim Barrett has updated the pull request incrementally with two additional commits since the last revision:
>
> - add pseudo-native entry for Reference.get0
> - tidy CallGenerator lookup in Compile ctor
Marked as reviewed by vlivanov (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24315#pullrequestreview-2905801629
More information about the hotspot-dev
mailing list