RFR: 8352075: Perf regression accessing fields [v23]

[Coleen Phillimore]

On Mon, 9 Jun 2025 06:40:48 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> The addition of read_name_and_signature() is a good level of abstraction.
>
> We must have some misunderstanding. This is not `FieldInfoStream`, this is `FieldInfoReader::read_field_info`, therefore I don't see any issue accessing private `FieldInfoReader::_r`. I've removed all friend classes from `FieldInfoReader` - noone outside `FieldInfoReader` can see `_r`.

Sorry, it's FieldInfoReader.  I think the next_uint() is a helpful function in that class to keep the _r.thing() pattern to a minimum. I don't think the changes here are an improvement.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24847#discussion_r2135820196