RFR: 8352075: Perf regression accessing fields [v27]

[Coleen Phillimore]

On Mon, 9 Jun 2025 14:38:47 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix coding style
>
> src/hotspot/share/utilities/packedTable.cpp line 64:
> 
>> 62:     assert((value & ~_value_mask) == 0, "value out of bounds: %x vs. %x (%x)", value, _value_mask, ~_value_mask);
>> 63:     uint64_t element = static_cast<uint64_t>(key) | (static_cast<uint64_t>(value) << _value_shift);
>> 64:     __builtin_memcpy(table + offset, &element, _element_bytes);
> 
> Looking at this is context makes more sense.  We don't have __builtin_memcpy in the sources, just memcpy.  Assuming the platform will do the right thing.

The memcpy is better than what was there before.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24847#discussion_r2135863534