RFR: 8344165: Trace exceptions with a complete call-stack [v4]

Ioi Lam iklam at openjdk.org
Tue Jun 10 00:05:55 UTC 2025


On Fri, 30 May 2025 06:45:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use -Xlog:exceptions+stacktrace instead; fixed typo in comments
>
> src/hotspot/share/utilities/exceptions.cpp line 620:
> 
>> 618:   if (st.is_enabled()) {
>> 619:     Thread* t = Thread::current_or_null();
>> 620:     if (t != nullptr && t->is_Java_thread()) { // sanity
> 
> Do we need this? If we just rely on assertions then all we need is to call `JavaThread::current`.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25522#discussion_r2136685631


More information about the hotspot-dev mailing list