RFR: 8347273: C2: VerifyIterativeGVN for Ideal and Identity [v3]

[Christian Hagedorn]

On Tue, 10 Jun 2025 09:28:21 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/phaseX.cpp line 1803:
>> 
>>> 1801:   }
>>> 1802:   tty->print_cr("The result after Ideal:");
>>> 1803:   i->dump_bfs(1, nullptr, "");
>> 
>> Perhaps taking the tty lock might be appropriate, due to the amount of printing? Or do we know that nothing else is printing?
>
> good idea!

You could also define a `stringStream ss` and pass that one to `dump_bfs()`. We do a similar thing for `print_ideal_ir()` to keep everything in a block. As a bonus: We don't suffer from a tty lock being broken - even though that would not affect correctness.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22970#discussion_r2137461406