RFR: 8347273: C2: VerifyIterativeGVN for Ideal and Identity [v3]

[Emanuel Peter]

On Tue, 10 Jun 2025 10:12:50 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/hotspot/share/opto/phaseX.cpp
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>>  - review suggestions, and handled a few more edge cases
>
> src/hotspot/share/opto/phaseX.cpp line 1090:
> 
>> 1088:       if (is_verify_Ideal())    { failure |= verify_node_Ideal(n, false); }
>> 1089:       if (is_verify_Ideal())    { failure |= verify_node_Ideal(n, true); }
>> 1090:       if (is_verify_Identity()) { failure |= verify_node_Identity(n); }
> 
> Suggestion: How about naming them `verify_Value/Ideal/Identity_for(n)`?

I don't care. For me they are equally good :)
I'll change it to your suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22970#discussion_r2137685509