RFR: 8347273: C2: VerifyIterativeGVN for Ideal and Identity [v5]

[Emanuel Peter]

On Tue, 10 Jun 2025 13:00:40 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use stringStream instead of ttyLocker
>
> src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp line 303:
> 
>> 301: JVMFlag::Error VerifyIterativeGVNConstraintFunc(uint value, bool verbose) {
>> 302:   uint original_value = value;
>> 303:   for (int i = 0; i < 4; i++) {
> 
> You might want to consider adding a `const int max_modes = 4` or something like that and use it also below in the error message.

Sure, I can do that :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22970#discussion_r2137883591