RFR: 8344165: Trace exceptions with a complete call-stack [v4]
Ioi Lam
iklam at openjdk.org
Tue Jun 10 18:36:34 UTC 2025
On Tue, 10 Jun 2025 12:38:43 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> The output is printed only if the failure happens in `OutputAnalyzer::shouldMatch()`, etc. I've updated the test so failures can happen other ways, so I cannot rely on this anymore.
>
> Sorry I don't follow. I'm saying there is no need to print stdout here because upon failure it will be printed anyway. If you want to see stdout even in passing cases then do this after all the `shouldXXX` checks.
I fixed the test case to do all checks with `shouldXXX()`, and removed the stdout printing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25522#discussion_r2138546558
More information about the hotspot-dev
mailing list