RFR: 8357086: os::xxx functions returning memory size should return size_t [v5]
Severin Gehwolf
sgehwolf at openjdk.org
Wed Jun 11 15:03:38 UTC 2025
On Wed, 11 Jun 2025 09:53:17 GMT, Anton Artemov <duke at openjdk.org> wrote:
>> Hi,
>>
>> in this PR the output value type for functions which return memory are changed, namely:
>>
>>
>> static julong available_memory(); --> static size_t available_memory();
>> static julong used_memory(); --> static size_t used_memory();
>> static julong free_memory(); --> static size_t free_memory();
>> static jlong total_swap_space(); --> static ssize_t total_swap_space();
>> static jlong free_swap_space(); --> static ssize_t free_swap_space();
>> static julong physical_memory(); --> static size_t physical_memory();
>>
>>
>> The changes are done so that the other parts of the code have minimal impact.
>> Tested in GHA and Tiers 1-4.
>
> Anton Artemov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>
> - Merge remote-tracking branch 'origin/master' into JDK-8357086_size_t_memfuncs
> - 8357086: Fixed spaces in formatting in gc-related code.
> - 8357086: Fixed formatting.
> - 8357086: Addressed reviewer's comments.
> - 8357086: More work.
> - 8357086: More work.
> - 8357086: More work.
> - 8357086: More work.
> - 8357086: More work.
> - 8357086: More work
> - ... and 2 more: https://git.openjdk.org/jdk/compare/afaa2a88...f3a5f61c
src/hotspot/os/linux/os_linux.cpp line 261:
> 259: }
> 260: log_trace(os)("available memory: " JULONG_FORMAT, avail_mem);
> 261: return static_cast<size_t>(avail_mem);
Line 243 should probably receive the same treatment (of `static_cast`)?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2140360647
More information about the hotspot-dev
mailing list