RFR: 8358815: Exception event spec has stale reference to catch_klass parameter [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Jun 11 18:12:50 UTC 2025
On Wed, 11 Jun 2025 06:00:31 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Thank you for the comments!
>> Yes, I've also come to the same conclusion about the only `catch_method == null` check.
>>
>>> Then you also need to fix:
>>> "If there is no such catch clause, each field is set to 0."
>>
>> Good catch, thanks.
>>
>> The suggestions above have addressed now.
>> Also, I've replaced the term `field` with `parameter` for consistency in two spots.
>
> I think what you have looks okay now. I'm just wondering about the description for the catch_location parameter has "zero if no known catch". So if catch_method is null then catch_location must be 0.
Thank you, Alan. I've updated the event description.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25710#discussion_r2140791431
More information about the hotspot-dev
mailing list