RFR: 8357826: Avoid running some jtreg tests when asan is configured [v8]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Jun 11 21:14:30 UTC 2025
On Wed, 11 Jun 2025 11:42:13 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> There are a couple of jtreg tests, especially in the HS area, with very special assumptions about memory layout/sizes .
>> Those fail when the address sanitizer is configured ( --enable-asan ).
>> The change adds a way to tag those tests with 'requires' so that they can be avoided easily when running jtreg tests with ASAN enabled.
>> Adjusting the tests for "pleasing" the sanitizer is not always desired (if possible for some tests it can be done later) .
>> While at it, also same is also added for ubsan .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Add comment
This looks good. I've posted one nit though.
src/hotspot/share/prims/whitebox.hpp line 77:
> 75: static bool is_asan_enabled();
> 76: static bool is_ubsan_enabled();
> 77: };
Nit: I'd suggest to add a short comments explaining what `asan` and `ubsan` mean.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25575#pullrequestreview-2918761842
PR Review Comment: https://git.openjdk.org/jdk/pull/25575#discussion_r2141125695
More information about the hotspot-dev
mailing list