RFR: 8358329: AArch64: emit direct branches in static stubs for small code caches [v2]

Mikhail Ablakatov mablakatov at openjdk.org
Thu Jun 12 08:45:29 UTC 2025


On Thu, 12 Jun 2025 07:43:52 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Mikhail Ablakatov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comments: use pd_patch_instruction directly
>>   
>>   MacroAssembler::pd_patch_instruction can distinguish between the `b`
>>   and `movk movz movz br` sequences. Strictly speaking, the method
>>   patches not a single instruction but a semantically joint sequence of
>>   instructions. Use it directly instead of `NativeJump` and
>>   `NativeGeneralJump` wrapper classes to simplify the implementation and
>>   get rid of an extra icache invalidation.
>>   
>>   Other changes in the patch simply clean up code that became redundant.
>
> src/hotspot/cpu/aarch64/nativeInst_aarch64.hpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 1997, 2025, Oracle and/or its affiliates. All rights reserved.
>> 3:  * Copyright (c) 2014, 2108, Red Hat Inc. All rights reserved.
> 
> Suggestion:
> 
>  * Copyright (c) 2014, 2025, Red Hat Inc. All rights reserved.

JIC, the patch doesn't touch this line. Git blame indicates the last time Red Hat's copyright was updated is 2018. Should I replace it with `2018` instead of `2025`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25702#discussion_r2142078515


More information about the hotspot-dev mailing list