RFR: 8357086: os::xxx functions returning memory size should return size_t [v9]
Anton Artemov
duke at openjdk.org
Fri Jun 13 09:56:52 UTC 2025
On Thu, 12 Jun 2025 18:15:33 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Anton Artemov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
>>
>> - 8357086: Fixed merge conflict.
>> - 8357086: Changed returm type to struct.
>> - 8357086: Return size_t from swap mem funcs, added checks.
>> - 8357086: Added missed casts.
>> - 8357086: Changed return type for total_swap_space and free_swap_space to ssize_t
>> - Merge remote-tracking branch 'origin/master' into JDK-8357086_size_t_memfuncs
>> - 8357086: Fixed spaces in formatting in gc-related code.
>> - 8357086: Fixed formatting.
>> - 8357086: Addressed reviewer's comments.
>> - 8357086: More work.
>> - ... and 7 more: https://git.openjdk.org/jdk/compare/e18277b4...dd9275ca
>
> src/hotspot/share/runtime/os.hpp line 151:
>
>> 149: struct MemRes {
>> 150: size_t val;
>> 151: int err;
>
> I'm not a big fan of abbreviations like this. My preference would be to at least spell out "value".
> Don't know what others might think.
I changed the variables names to full words for better readability, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25450#discussion_r2144660606
More information about the hotspot-dev
mailing list