RFR: 8359227: Code cache/heap size options should be size_t [v2]

SendaoYan syan at openjdk.org
Sat Jun 14 00:55:36 UTC 2025


On Fri, 13 Jun 2025 18:46:58 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change that makes the various code cache/heap size options
>> consistently be of type size_t.
>> 
>> The shared declarations for these options were all uintx. These options all
>> may have platform-defined values. Some of those platform-specific definitions
>> were uintx, some were size_t, and some were intx(!). This change makes them
>> all consistently size_t.
>> 
>> More details in the first comment.
>> 
>> Testing: mach5 tier1-6
>> GHA testing in-progress
>
> Kim Barrett has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - update copyrights
>  - remove leftover <type_traits> include

test/lib-test/jdk/test/whitebox/vm_flags/UintxTest.java line 40:

> 38: public class UintxTest {
> 39:     private static final String FLAG_NAME = "VerifyGCStartAt";
> 40:     private static final String FLAG_DEBUG_NAME = "StopInterpreterAt";

Hi, Does this change is a mistake. Why do we change the `FLAG_DEBUG_NAME`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25791#discussion_r2146323772


More information about the hotspot-dev mailing list