RFR: 8359227: Code cache/heap size options should be size_t [v2]

Kim Barrett kbarrett at openjdk.org
Mon Jun 16 19:55:28 UTC 2025


On Mon, 16 Jun 2025 19:05:12 GMT, Larry Cable <duke at openjdk.org> wrote:

>> I'd rather not. I'm not a fan of this kind of formatting. I moved the `ADD_FLAG` calls over to
>> maintain the pre-existing formatting after adding the longer than anything else `ADD_SIZE_T_FLAG`,
>> but the `ADD_FLAG` arguments were not lined up and I'd just as soon leave them that way.
>
> not sure being a fan or not is sufficient reason...

Leaving it as is maintains the status quo. I'm not proposing to delete the extra whitespace in front of
`ADD_FLAG`, which would be my preferred layout. And the comment does say "feel free to ignore".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25791#discussion_r2150756646


More information about the hotspot-dev mailing list